Drop Suggests: RColorBrewer#6851
Open
arcresu wants to merge 2 commits into
Open
Conversation
arcresu
force-pushed
the
drop-RColorBrewer
branch
from
479d8c0 to
985c736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not correspond to an issue, but by chance I noticed that the only place
RColorBrewerwas used was in the script for generating icons. I replaced it with the equivalent call topal_brewer()and dropped the dependency. The only remaining reference toRColorBreweris inman/scale_brewer.Rd, pulled in indirectly by@inheritParams scales::pal_brewer.The unrelated bugfix is just because the icon script wouldn't run as
gwas undefined at that line.